Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Colors" to "0.12" #124

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Colors package from 0.9, 0.10, 0.11 to 0.9, 0.10, 0.11, 0.12.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented Mar 14, 2020

Codecov Report

Merging #124 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #124   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files           9        9           
  Lines         395      395           
=======================================
  Hits          238      238           
  Misses        157      157

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a2f1b...ce0c208. Read the comment docs.

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 14, 2020

Hmmm... Looks like we're hitting an incompatibility issue here: a GitHub action can't trigger another GitHub action, so CI tests defined by Github Action are not invoked in this case.

There is no good solution for this as far as I can tell

@kimikage
Copy link

kimikage commented Mar 15, 2020

cf. JuliaGraphics/Graphics.jl@78c8259

I sent a PR, but I do not have the merging permission. JuliaGraphics/Graphics.jl#21

Edit:
@timholy released Graphics v1.0.2. 🎉 JuliaRegistries/General#10993

@kimikage
Copy link

kimikage commented Mar 15, 2020

BTW, why is this "1.0" instead of "1"?

Graphics = "0.4, 1.0"

Edit:
As shown below, the range is the same. I meant "1.0" is somewhat confusing.

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 15, 2020

In this case, "1.0" is equivalent to "1"; both mean [1.0.0, 2.0.0)

https://julialang.github.io/Pkg.jl/v1/compatibility/#Version-specifier-format-1

@kimikage
Copy link

kimikage commented Mar 15, 2020

FYI, in my local environment (with modified ColorVectorSpace), the tests passed.

Edit:
Just to let you know, "modified" simply means change of "[compat]" and elimination of isless. No functionality has been changed.

@johnnychen94
Copy link
Member

Thanks, I was waiting for a new ColorVectorSpace release 😄

Perhaps it's time to get a new release. I've seen people complaining about ImageCore not compatible with FixedPointNumber v0.8 in slack.

@timholy
Copy link
Member

timholy commented Mar 15, 2020

ColorVectorSpace may take another few days, I am trying to finish off JuliaSIMD/LoopVectorization.jl#66

@johnnychen94
Copy link
Member

johnnychen94 commented Mar 15, 2020

Given that I plan to tag a new release tonight 👻

Am updating docs.

@johnnychen94 johnnychen94 merged commit 33acb81 into master Mar 15, 2020
@johnnychen94 johnnychen94 deleted the compathelper/new_version/2020-03-14-00-09-20-705-3741353315 branch March 15, 2020 22:14
@timholy
Copy link
Member

timholy commented Mar 17, 2020

Since ColorVectorSpace is starting to look like a bottleneck, and I'm a bit stuck on JuliaSIMD/LoopVectorization.jl#76, I'll task-switch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants