-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for "Colors" to "0.12" #124
CompatHelper: bump compat for "Colors" to "0.12" #124
Conversation
Codecov Report
@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 60.25% 60.25%
=======================================
Files 9 9
Lines 395 395
=======================================
Hits 238 238
Misses 157 157 Continue to review full report at Codecov.
|
Hmmm... Looks like we're hitting an incompatibility issue here: a GitHub action can't trigger another GitHub action, so CI tests defined by Github Action are not invoked in this case. There is no good solution for this as far as I can tell |
cf. I sent a PR, but I do not have the merging permission. JuliaGraphics/Graphics.jl#21 Edit: |
BTW, why is this "1.0" instead of "1"? Line 18 in 73a2f1b
Edit: |
In this case, https://julialang.github.io/Pkg.jl/v1/compatibility/#Version-specifier-format-1 |
FYI, in my local environment (with modified ColorVectorSpace), the tests passed. Edit: |
Thanks, I was waiting for a new ColorVectorSpace release 😄 Perhaps it's time to get a new release. I've seen people complaining about ImageCore not compatible with FixedPointNumber v0.8 in slack. |
ColorVectorSpace may take another few days, I am trying to finish off JuliaSIMD/LoopVectorization.jl#66 |
Given that I plan to tag a new release tonight 👻 Am updating docs. |
Since ColorVectorSpace is starting to look like a bottleneck, and I'm a bit stuck on JuliaSIMD/LoopVectorization.jl#76, I'll task-switch. |
This pull request changes the compat entry for the
Colors
package from0.9, 0.10, 0.11
to0.9, 0.10, 0.11, 0.12
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.