Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect LLVM_INCLUDE path (and possibly LLVM_LIBDIR) #273

Closed
jessymilare opened this issue Oct 26, 2020 · 1 comment · Fixed by #274
Closed

Incorrect LLVM_INCLUDE path (and possibly LLVM_LIBDIR) #273

jessymilare opened this issue Oct 26, 2020 · 1 comment · Fixed by #274

Comments

@jessymilare
Copy link

The path to LLVM include directory is wrong.

julia> Clang.LLVM_LIBDIR
"C:\\Users\\jessy\\.julia\\artifacts\\3135abc6132c4619d21c4edd03e416c2c46e3bec\\bin"

julia> isdir(ans)
true

julia> Clang.LLVM_INCLUDE
"C:\\Users\\jessy\\.julia\\artifacts\\3135abc6132c4619d21c4edd03e416c2c46e3bec\\bin\\clang\\9.0.1\\include"

julia> isdir(ans)
false

Perhaps the correct definition of the constants (in Clang.jl file) should be:

const LLVM_BINDIR = dirname(LibClang.Clang_jll.libclang_path)
const LLVM_LIBDIR = joinpath(dirname(LLVM_BINDIR), "lib")
const LLVM_INCLUDE = joinpath(LLVM_LIBDIR, "clang", LLVM_VERSION, "include")
const CLANG_INCLUDE = LLVM_INCLUDE
@Gnimuc
Copy link
Member

Gnimuc commented Oct 27, 2020

Nice catch! I didn't test this on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants