Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused type parameter #456

Merged
merged 3 commits into from
Apr 14, 2023
Merged

remove unused type parameter #456

merged 3 commits into from
Apr 14, 2023

Conversation

palday
Copy link
Collaborator

@palday palday commented Oct 5, 2022

Julia 1.8.2 warns about unused type parameters

closes #479, closes #478

@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b4afc92) 76.86% compared to head (235814f) 76.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #456   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files          25       25           
  Lines        1664     1664           
=======================================
  Hits         1279     1279           
  Misses        385      385           
Impacted Files Coverage Δ
src/convert/base.jl 90.39% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palday
Copy link
Collaborator Author

palday commented Oct 5, 2022

The Windows failures look unrelated and just due to some connection flakiness. @randy3k could you restart them?

@ViralBShah ViralBShah closed this Oct 18, 2022
@ViralBShah ViralBShah reopened this Oct 18, 2022
@ViralBShah
Copy link
Contributor

There seems to be a problem with the R install on Windows.

@ViralBShah
Copy link
Contributor

Ok to merge?

@lbilli lbilli mentioned this pull request Dec 30, 2022
@lbilli lbilli mentioned this pull request Feb 11, 2023
@ararslan ararslan merged commit 28a0a46 into JuliaInterop:master Apr 14, 2023
8 checks passed
@palday palday deleted the patch-1 branch April 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning when precompiling under julia v1.9.0-beta4
3 participants