Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #478 #479

Closed
wants to merge 1 commit into from
Closed

Fix issue #478 #479

wants to merge 1 commit into from

Conversation

dmbates
Copy link
Member

@dmbates dmbates commented Feb 11, 2023

Trivial fix that removes a warning when precompiling RCall under julia v1.9.0-beta4 and later

@dmbates
Copy link
Member Author

dmbates commented Feb 11, 2023

It seems that the test failures are unrelated to the change. I can't reproduce the test failures locally.

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9a9057f) 75.67% compared to head (98ba23b) 75.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #479   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files          24       24           
  Lines        1640     1640           
=======================================
  Hits         1241     1241           
  Misses        399      399           
Impacted Files Coverage Δ
src/convert/base.jl 89.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lbilli
Copy link
Contributor

lbilli commented Feb 11, 2023

Ref #456 and #474

@ararslan ararslan closed this Apr 14, 2023
@ararslan ararslan reopened this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants