Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in Core._apply_iterate overdubbing, args[1] also needs to be overdubbed #163

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

KristofferC
Copy link
Contributor

Fixes #162

Also fixes the test for Glfops.jl on 1.4 (triscale-innov/GFlops.jl#6)

@vchuravy
Copy link
Member

Thanks. What is argument 1? Isn't it the state given to the iterate function?

@vchuravy vchuravy merged commit 2e0827a into JuliaLabs:master Jan 27, 2020
@KristofferC
Copy link
Contributor Author

KristofferC commented Jan 27, 2020

Heh, I was just gonna say to hold off on merging this for a bit :P. I was trying to get through the test failures on 1.4 and found that this seems to have broken something else.

@KristofferC
Copy link
Contributor Author

For example,

julia> f(a,b) = *(a, b...)
f (generic function with 1 method)

julia> @code_lowered f(1,2)
CodeInfo(
1 ─ %1 = Core.tuple(a)
│   %2 = Core._apply_iterate(Base.iterate, Main.:*, %1, b)
└──      return %2
)

Here, args[1] is the multiplication * that we also want to overdub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More problems with _apply_iterate?
2 participants