Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for 1.10 #205

Merged
merged 6 commits into from
Aug 17, 2023
Merged

Conversation

oscardssmith
Copy link
Contributor

JuliaLang/julia#48766 makes it so retrieve_code_info takes in a worldage, and dramatically simplifies construction of .

oscardssmith and others added 2 commits August 7, 2023 10:12
@oscardssmith oscardssmith changed the title Oscardssmith update for 1.10 update for 1.10 Aug 7, 2023
@oxinabox
Copy link
Contributor

oxinabox commented Aug 8, 2023

Also needs to actually define an overload of __overdub_generator__ which accepts a world-age etc.

@oscardssmith
Copy link
Contributor Author

This still has 1 erroring test and 2 failing but that predates this PR. 1.10 now works as well as 1.9.

@oxinabox
Copy link
Contributor

oxinabox commented Aug 9, 2023

Can we mark those tests as broken so we can merge this?

They don't look important, but I am not sure.

@oscardssmith
Copy link
Contributor Author

I figure they're not that important given that they're also broken in Julia 1.9

@oscardssmith
Copy link
Contributor Author

Unfortunately the errors on 1.9 were actually hiding errors that were happening later on in the code. commit incoming.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 11.11% and project coverage change: -4.15% ⚠️

Comparison is base (fae23e7) 85.38% compared to head (c7a62c3) 81.24%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   85.38%   81.24%   -4.15%     
==========================================
  Files           6        6              
  Lines         787      773      -14     
==========================================
- Hits          672      628      -44     
- Misses        115      145      +30     
Files Changed Coverage Δ
src/overdub.jl 86.16% <11.11%> (-6.98%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxinabox
Copy link
Contributor

Looking at the last 2 failures.
It looks like they both should be handled with:

if VERSION>v"1.9"
    @test ...
else
   @test ...

because I think both old and new answer is correct and it just represents a nonsemantic change in the internals.
The numbers are all the same.
just the addition of a core._apply operation.

@oscardssmith
Copy link
Contributor Author

oscardssmith commented Aug 15, 2023

Good call. All 1.6 and 1.9 tests are now passing. I believe this is ready to merge.

@vchuravy vchuravy merged commit 4dbe9b1 into JuliaLabs:master Aug 17, 2023
8 of 14 checks passed
@oscardssmith oscardssmith deleted the oscardssmith-update-for-1.10 branch August 17, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants