Run CI against Julia 1.0 #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `1.0` in YAML gets automatically converted to `1` which results in the latest version of Julia 1 being run and not the latest version of 1.0. I quoted the other Julia version numbers just to be consistent.
|
FYI: @timholy |
Codecov Report
@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 75.38% 80.21% +4.83%
==========================================
Files 4 4
Lines 455 455
==========================================
+ Hits 343 365 +22
+ Misses 112 90 -22
Continue to review full report at Codecov.
|
|
🎉 Luckily none of the Compat additions since we switched to GHA broke Julia 1.0 support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
1.0in YAML gets automatically converted to1which results in the latest version of Julia 1 being run and not the latest version of 1.0. I quoted the other Julia version numbers just to be consistent.Introduced in #739