-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keepat! #770
add keepat! #770
Conversation
Codecov Report
@@ Coverage Diff @@
## master #770 +/- ##
==========================================
+ Coverage 88.35% 89.08% +0.72%
==========================================
Files 2 2
Lines 146 174 +28
==========================================
+ Hits 129 155 +26
- Misses 17 19 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (modulo adding the requested comment), but needs a rebase.
@martinholters - let us discuss how to handle the following issue. DataFrames.jl has support back to Julia 1.0. Therefore we need this PR both in 4.0 and 3.x branches of Compat.jl. How would you like me to handle this? Thank you! |
I have rebased the PR. Following the discussion in #767 after this PR is merged it should be backported to 3.x branch and both 3.x. and 4.x. releases should be done. Thank you! |
Co-authored-by: Martin Holters <martin.holters@hsu-hh.de>
@@ -1,6 +1,6 @@ | |||
name = "Compat" | |||
uuid = "34da2185-b29b-5c13-b0c7-acf172513d20" | |||
version = "4.0.0" | |||
version = "4.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that 4.0.0 has been yanked, should this be 4.0.1? @KristofferC?
Are we ok with merging and tagging this as 4.1.0? @KristofferC? |
Thank you! How do we go about now to making a backport of this PR to 3.x branch and making a release? |
You create a branch off of |
Fixes #750