fix: use invokelatest for easy_hook, avoid race #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- uses `Base.invokelatest` while invoking `easy_hook` methods because the downloads instance and callbacks may be in different world ages. - stores the `easy_hook` in local var to avoid races that cn happen between checking and invoking fixes JuliaLang#240
quinnj
approved these changes
Apr 20, 2024
StefanKarpinski
approved these changes
Apr 20, 2024
|
The CI failures look unrelated. |
|
I don't understand why GitHub has made it absolutely impossible to rerun failed CI jobs, but decoded to yolo it here after spending 15 minutes looking for some kind of rerun job button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base.invokelatestwhile invokingeasy_hookmethods because the downloads instance and callbacks may be in different world ages.easy_hookin local var to avoid races that cn happen between checking and invokingfixes #240