only run precompile workload when generating output #243
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise we run code at module load each time.
This is not really true, the toplevel code only runs during precompilation (or if you load the module and have turned off precompilation). |
|
Seems like this change is desirable so that this code isn't run when recompilation is off though, no? |
|
I should have clarified that the main rationale for this is to make Downloads work at I supposed backwards compat needs to be fixed as well. |
|
Note that #242 is also required for |
|
This fails on earlier julia versions, I think you need to use the ccall to be compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise we run code at module load each time.