Fix deprecation warnings, remove v0.3 support #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module SortingAlgorithms | ||
|
|
||
| using Compat | ||
| import Compat.view |
There was a problem hiding this comment.
put a minimum version on Compat in REQUIRE
|
The reason this is failing is because StatsBase does not support v0.3. I used StatsBase because the |
|
I think dropping 0.3 support here is fine. |
ranjanan
changed the title
|
@kmsquire @tkelman @ViralBShah Could one of you guys tag a new version? Thanks. |
|
(will have to be a new minor version via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add REQUIRE file to tests for StatsBase, because
histis deprecated, andsubis nowview