-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stringapalooza #16107
Comments
Great list. What about windows APIs that use utf-16? |
Already taken care of: #15033. Two more potential rounds:
Might not get to those until the next release though. |
What about:
I definitely think there's a lot to play with around merging Substring and String, but it certainly feels like 0.6 material. |
It was just added, but now that |
just for my curiosity: Why should this be part of 0.5? The title of the release had something to do with Arrays ... not Strings? |
+1 for including as much of this plan as possible into 0.5. Breakage better happen soon. As regards moving As regards changing EDIT: Finally, I'd like to see a discussion regarding the opportunity of ensuring that |
Because I've been working on this for months and it's ready to go. It won't hold up the release anyway. |
I somehow agree, it will not hold the release of the language. But more syntax changes in 0.5 give some impact in porting packages to 0.5; maybe i'm just wrong that this causes effort ... |
And more syntax changes in 0.6 will cause effort for even more packages. And given the growth rate of the package ecosystem... |
#15033 didn't fully provide a path for external packages to call Windows APIs, without calling internal functions. |
True – added to the roadmap. |
Actually, question here: do people think we should keep |
Another question about behavior. julia> String(UInt8[97,98,99])
"abc"
julia> string(UInt8[97,98,99])
"UInt8[97,98,99]" Any thoughts on resolving this? Currently |
Maybe There is also the |
I'm pretty sure that usage of |
|
This case doesn't bother me that much --- unlike |
The point is, we need some function to replace It makes sense to me to name them all the same thing, with |
Can we just keep |
@JeffBezanson, |
I'm not prepared to make this the first ever case where |
Then what do we call the non-copying version(s) of |
I've probably missed some of the discussion here, but can |
@JeffBezanson, the problem is that then it can't replace |
That's fine with me. Somehow we need one function that wraps a UInt8 vector as a string, and another that gives you the output of |
TODO: |
Ref #16499. Also need a way to express conversion of |
@StefanKarpinski, in previous incarnations, any |
Which items are slated for 0.5? Through round 3, IIRC? |
Yes, that's correct. Tomorrow/Wednesday I need to create a LegacyStrings package, put all the Unicode stuff in it and then merge my PR that removes all of that stuff with deprecations that point at it. |
PR is up to remove RepString; it has already been added to LegacyStrings. RevString is used by some Base functions so we might want to leave it for now. Anything else here planned for 0.6? |
While you're doing string stuff, it's probably not too hard to just actually do utf-8 reversal on strings instead of using the |
Other than removing |
0.5 Major tasks
Round 1
ASCIIString
,UTF8String
andByteString
intoString
, replace ASCIIString & UTF8String with String #16058String
, String: alias for new String or old UTF8String Compat.jl#192Round 2
utf8
,bytestring
andwithstring
String
, replace bytestring with String #16453, deprecate utf8 for String #16469s = ascii(s)
withs = String(s); isascii(s) || error(...)
, ascii: only support checking String for pure ASCIIness #16396Round 3
String
constructor is bad #16713, restore non-copying String behavior, add unsafe_string*, ... #16731Cwstring
deprecate WString and wstring #16975, Base.transcode to replace utf8to16 and utf16to8 #16974UTF16String
andUTF32String
remove UTF-16 and UTF-32 stuff #16590Cleanup tasks
LineEdit
test change, replace ASCIIString & UTF8String with String #16058 (comment), fix: fix mystery REPL test change introduced by 5de52cf9c9343cfcf50be4c #16198String
inner constructor, replace ASCIIString & UTF8String with String #16058 (comment)String
inner constructor, replace ASCIIString & UTF8String with String #16058 (comment)jl_is_utf8_string
andjl_is_byte_string
withjl_is_string
, replace ASCIIString & UTF8String with String #16058 (comment)ascii
inuv_getaddrinfo
to error on non-ASCII domain names, replace ASCIIString & UTF8String with String #16058 (comment)ascii
in SuiteSparse to error on non-ASCII inputs,replace ASCIIString & UTF8String with String #16058 (comment)
String
type, 5de52cf#commitcomment-17373792, Fix printing ofTypeVar
with lower bound. #16221readdlm
'signore_invalid_chars
option, replace ASCIIString & UTF8String with String #16058 (comment), e95f5f2readdlm
'signore_invalid_chars
option 969d61bconnect
in docs,doc/manual/interacting-with-julia.rst
(with doctests), replace ASCIIString & UTF8String with String #16058 (comment)0.6 Major tasks
Round 4
Char
representation (allow lossless string processing of any data)RepString
(moved to LegacyStrings)RevString
(move to package?)SubString
andString
(add offset field toString
)Cleanup tasks
prevind("ll", 5)
and such errors, replace ASCIIString & UTF8String with String #16058 (comment)replace ASCIIString & UTF8String with String #16058 (comment)
isspace
implementation, replace ASCIIString & UTF8String with String #16058 (comment)convert
method breaks bootstrap, replace ASCIIString & UTF8String with String #16058 (comment)takebuf
API, replace ASCIIString & UTF8String with String #16058 (comment), Simplify takebuf() API #19088The text was updated successfully, but these errors were encountered: