Pkg.submit doesn't work on windows; no which

[quinnj]

Not sure why, but it seems that mingw64/msys2 don't come with a working version of which (there seems to be something in msys2, but it said it was 32-bit for me...). Anyway, this prevents Pkg.submit from working because of the call to success("which curl') || error(.... My system does, however, have a working version of curl and commenting ou the success call allowed me to use the machinery just fine. Not sure the best way to check if a program exists on windows or if it just letting it error out is ok.

[quinnj]

I just found a superuser question that suggests using where [cmd] as an option to just check for a program's location/existence. That's a possibility.

http://superuser.com/questions/34492/powershell-equivalent-to-unix-which-command

[StefanKarpinski]

Oh Windows. Well, if you can patch this to work on Windows using where, we can merge that.

[tkelman]

In msysgit, which is this shell script https://github.com/msysgit/msysgit/blob/master/bin/which that calls type -p $1

[vtjnash]

where is not typically available on windows according to that SO post.

I think you can just eagerly execute the curl command, since you can distinguish between process failed and process not found. (or, like WinRPM, you could use IE to download files, since that's likely to be properly configured on windows to punch through the firewall as needed, and it's always available)

[StefanKarpinski]

I think you can just eagerly execute the curl command, since you can distinguish between process failed and process not found.

Yeah, that's a good point.

[quinnj]

Should we still check for curl on unix then? And just eval on windows? I can patch this up quick if so.