Enum inner reworking to remove usage of Val{T} #10315
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ha, we did this at the same time. We'll have to combine the best of both; you have some improvements that I don't. I like your improved next/done. Not only faster, but |
|
Do you want to merge the two versions, or should I? |
|
I could do it later tonight, but feel free if you can get to it first. |
|
Ok I'll do it. |
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See @JeffBezanson's comments here for an enlightening discussion on the performance of using
Val{T}for restricting enum values.Also addresses his comments here and incorporates @jakebolewski's proposal in #10309 to disallow duplicate enum member values.