Replace sizeof(jl_tagged_value_t) with sizeof(void*) for MSVC

[tkelman]

This (along with one small int128 patch, not included with this PR) results in a successful MSVC-built julia repl, see discussion at 8b8b261#commitcomment-11018031

MSVC was getting a different answer for sizeof(jl_taggedvalue_t) because there are some GNU extension tricks that make the current "types as C structs" arrangement work.

Amazingly all the linalg tests pass (ccalling into a mingw-built openblas dll), there's a failure in numbers that's likely due to missing int128 intrinsics, and I still need to run the rest of the tests to get an idea what other failures there are several other failures to look into. See #7761 (comment) for instructions on how to build with MSVC - it currently downloads mingw-built dependency dll's from a nightly julia binary, but leveraging #11754 should eventually be able to make the build process less hacky, including building as many deps as possible with MSVC to make things msys and mingw-independent.

Should probably open an MSVC support tracking issue after this gets merged, to figure out how to manage any MSVC-only changes in base, get an MSVC-built Julia to properly identify itself as such, etc.

[JeffBezanson]

Awesome!

[tkelman]

(many thanks to @vtjnash for repeated debugging help and answering my various dumb questions over several months)

[vtjnash]

lgtm

(edit: looks like travis passed, but someone canceled the mac build causing the status here to look bad)

[tkelman]

MSVC build was broken again by the removal of sys.ji, this patch can bring it back https://gist.github.com/f8bf6baf23b28839ea30 when run with -J usr/lib/julia/sys.ji. That's not really suitable for committing though, a better fix involving using the MSVC linker to link the dll's should work when using recent LLVM (for comdat) but I don't have a build of that anywhere. I just sent a message to llvmdev asking whether their MSVC Windows binaries could include more than just clang in the future.

[ihnorton]

I just sent a message to llvmdev asking whether their MSVC Windows
binaries could include more than just clang in the future.

Maybe if we ask often enough :)
http://llvm.1065342.n5.nabble.com/ORC-jit-example-was-refs-to-LLVM-consultants-td80154.html#a80198

On Thu, Jul 2, 2015 at 12:40 AM, Tony Kelman notifications@github.com
wrote:

MSVC build was broken again by the removal of sys.ji, this patch can bring
it back https://gist.github.com/f8bf6baf23b28839ea30 when run with -J
usr/lib/julia/sys.ji. That's not really suitable for committing though, a
better fix involving using the MSVC linker to link the dll's should work
when using recent LLVM (for comdat) but I don't have a build of that
anywhere. I just sent a message to llvmdev asking whether their MSVC
Windows binaries could include more than just clang in the future.

—
Reply to this email directly or view it on GitHub
#11776 (comment).