Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Additional string tests for #11885 #11937

Merged
merged 1 commit into from Jun 30, 2015
Merged

RFC: Additional string tests for #11885 #11937

merged 1 commit into from Jun 30, 2015

Conversation

ghost
Copy link

@ghost ghost commented Jun 29, 2015

A stab at increasing test coverage for string.jl.

@ghost
Copy link
Author

ghost commented Jun 30, 2015

CI failures appears to be unrelated.

@ghost ghost changed the title Additional string tests for #11885 RFC: Additional string tests for #11885 Jun 30, 2015
@tkelman
Copy link
Contributor

tkelman commented Jun 30, 2015

@vtjnash does this backtrace from 32 bit travis resemble your theory about codegen inside finalizers?


signal (11): Segmentation fault
unknown function (ip: 0xb6fc5e69)
unknown function (ip: 0xb7350780)
unknown function (ip: 0xb73508ae)
unknown function (ip: 0xb735098d)
unknown function (ip: 0xb6df518c)
unknown function (ip: 0xb6df57de)
unknown function (ip: 0xb6df59da)
jl_generate_fptr at /home/travis/build/JuliaLang/julia/src/codegen.cpp:860
jl_trampoline_compile_function at /home/travis/build/JuliaLang/julia/src/builtins.c:964
jl_apply at /home/travis/build/JuliaLang/julia/src/julia.h:1346
run_finalizers at /home/travis/build/JuliaLang/julia/src/gc.c:153
__pool_alloc at /home/travis/build/JuliaLang/julia/src/gc.c:1053
jl_set_typeof at /home/travis/build/JuliaLang/julia/src/julia.h:117
jl_alloc_array_1d at /home/travis/build/JuliaLang/julia/src/array.c:331
jl_alloc_cell_1d at /home/travis/build/JuliaLang/julia/src/array.c:380
jl_gc_wb at /home/travis/build/JuliaLang/julia/src/julia.h:589
emit_expr at /home/travis/build/JuliaLang/julia/src/codegen.cpp:3285
emit_function at /home/travis/build/JuliaLang/julia/src/codegen.cpp:4690
jl_compile at /home/travis/build/JuliaLang/julia/src/codegen.cpp:908
jl_trampoline_compile_function at /home/travis/build/JuliaLang/julia/src/builtins.c:963
jl_apply at /home/travis/build/JuliaLang/julia/src/julia.h:1346
run_finalizers at /home/travis/build/JuliaLang/julia/src/gc.c:153
jl_atexit_hook at /home/travis/build/JuliaLang/julia/src/init.c:569
jl_exit at /home/travis/build/JuliaLang/julia/src/jl_uv.c:450
exit at client.jl:38
jlcall_exit_21497 at  (unknown line)
jl_apply at /home/travis/build/JuliaLang/julia/src/builtins.c:976
jl_apply at /home/travis/build/JuliaLang/julia/src/gf.c:1657
do_call at /home/travis/build/JuliaLang/julia/src/interpreter.c:66
eval at /home/travis/build/JuliaLang/julia/src/interpreter.c:212
jl_interpret_toplevel_expr at /home/travis/build/JuliaLang/julia/src/interpreter.c:28
jl_toplevel_eval_flex at /home/travis/build/JuliaLang/julia/src/toplevel.c:534
jl_toplevel_eval_flex at /home/travis/build/JuliaLang/julia/src/toplevel.c:400
jl_eh_restore_state at /home/travis/build/JuliaLang/julia/src/julia.h:1346
jl_f_top_eval at /home/travis/build/JuliaLang/julia/src/builtins.c:578
process_options at ./client.jl:293
_start at ./client.jl:405
unknown function (ip: 0xb51831d6)
jl_apply at /home/travis/build/JuliaLang/julia/src/builtins.c:976
jl_apply at /home/travis/build/JuliaLang/julia/src/gf.c:1659
unknown function (ip: 0x8049378)
unknown function (ip: 0x8048f58)
__libc_start_main at /lib/i386-linux-gnu/libc.so.6 (unknown line)
unknown function (ip: 0x8048f99)
exception on 2: ERROR: LoadError: test error in expression: readchomp(@cmd("\$exename -q -p 2 -P \"println(nworkers()); exit(0)\"")) == "2"
failed process: Process(`/tmp/julia/bin/julia -q -p 2 -P 'println(nworkers()); exit(0)'`, ProcessSignaled(11)) [0]
 in readbytes at process.jl:474
 in readchomp at io.jl:218
 in anonymous at test.jl:89
 in do_test at test.jl:49
 in anonymous at no file:69
 in include at ./boot.jl:254
 in runtests at /tmp/julia/share/julia/test/testdefs.jl:197
 in anonymous at multi.jl:837
 in run_work_thunk at multi.jl:590
 in anonymous at task.jl:837
 in readbytes at process.jl:474
 in readchomp at io.jl:218
 in anonymous at test.jl:89
 in do_test at test.jl:49
 in anonymous at no file:69
 in include at ./boot.jl:254
 in runtests at /tmp/julia/share/julia/test/testdefs.jl:197
 in anonymous at multi.jl:837
 in run_work_thunk at multi.jl:590
 in anonymous at task.jl:837
while loading /tmp/julia/share/julia/test/cmdlineargs.jl, in expression starting on line 3
    From worker 4:       * misc                 in  50.32 seconds
    From worker 5:       * ranges               in  94.64 seconds
    From worker 3:       * examples             in  45.50 seconds
ERROR: LoadError: LoadError: test error in expression: readchomp(@cmd("\$exename -q -p 2 -P \"println(nworkers()); exit(0)\"")) == "2"
failed process: Process(`/tmp/julia/bin/julia -q -p 2 -P 'println(nworkers()); exit(0)'`, ProcessSignaled(11)) [0]
 in anonymous at multi.jl:1327
 in anonymous at task.jl:1403
while loading /tmp/julia/share/julia/test/cmdlineargs.jl, in expression starting on line 3
while loading /tmp/julia/share/julia/test/runtests.jl, in expression starting on line 5
    From worker 2:       * cmdlineargs         

@tkelman tkelman added the test This change adds or pertains to unit tests label Jun 30, 2015
tkelman added a commit that referenced this pull request Jun 30, 2015
RFC: Additional string tests for #11885
@tkelman tkelman merged commit eecbe9f into JuliaLang:master Jun 30, 2015
@vtjnash
Copy link
Member

vtjnash commented Jul 1, 2015

yes

@ScottPJones ScottPJones mentioned this pull request Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test This change adds or pertains to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants