Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rectuangular full packed matrix support from base to LinearAlgebra.jl #12104

Merged
merged 1 commit into from
Jul 13, 2015

Conversation

andreasnoack
Copy link
Member

The methods have never been exported or maintained so it should be safe to move them out of base. This also fixes #11072.

@tkelman
Copy link
Contributor

tkelman commented Jul 10, 2015

ref JuliaLinearAlgebra/GenericLinearAlgebra.jl@946cb42 - looks like these weren't tested here. If any registered packages are using these, it would be good to register LinearAlgebra and add this to Compat.

@kshyatt
Copy link
Contributor

kshyatt commented Jul 10, 2015

👍 This will dramatically improve linalg/lapack.jl's coverage stats and just be better.

@kshyatt kshyatt added the linear algebra Linear algebra label Jul 10, 2015
@andreasnoack
Copy link
Member Author

@tkelman The package will be registered when I've written some documentation and tests. I'd be very surprised if these functions are used in any package so I'll go ahead a merge this.

andreasnoack added a commit that referenced this pull request Jul 13, 2015
Move rectuangular full packed matrix support from base to LinearAlgebra.jl
@andreasnoack andreasnoack merged commit ab4f684 into master Jul 13, 2015
@andreasnoack andreasnoack deleted the anj/rectfull branch July 13, 2015 13:52
@tkelman
Copy link
Contributor

tkelman commented Jul 13, 2015

I'd be very surprised if these functions are used in any package

A grep can answer that question. @dmbates had asked about them, and it's entirely possible he's not the only person trying to do more exotic operations.

@kshyatt
Copy link
Contributor

kshyatt commented Jul 13, 2015

lapack.jl now has 93% test coverage. https://coveralls.io/builds/3047587

@StefanKarpinski
Copy link
Member

I find the coveralls UI completely confusing. I have basically no idea how to, e.g., find what the percentage coverage for that file is from that link.

@StefanKarpinski
Copy link
Member

When I did navigate to it (use the search thing), I see 89.02% coverage. Are we looking at the same thing?

@kshyatt
Copy link
Contributor

kshyatt commented Jul 13, 2015

I swear it was 93% a few minutes ago. Oh well. 89% is still really good.

@StefanKarpinski
Copy link
Member

Yes, it's great. This is really getting there.

@kshyatt
Copy link
Contributor

kshyatt commented Jul 13, 2015

I find the coveralls UI completely confusing. I have basically no idea how to, e.g., find what the percentage coverage for that file is from that link.

Is my guide at #11885 not clear enough? Could you suggest improvements?

@StefanKarpinski
Copy link
Member

No, your guide is great. I'm really just venting that their UI is lousy.

@kshyatt
Copy link
Contributor

kshyatt commented Jul 13, 2015

I think it's really cool that I have to click like 10 different things to get the information I want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linear algebra Linear algebra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LAPACK.trttf! and LAPACK.tfttr! do not mutate arguments
4 participants