-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move rectuangular full packed matrix support from base to LinearAlgebra.jl #12104
Conversation
ref JuliaLinearAlgebra/GenericLinearAlgebra.jl@946cb42 - looks like these weren't tested here. If any registered packages are using these, it would be good to register LinearAlgebra and add this to Compat. |
👍 This will dramatically improve |
@tkelman The package will be registered when I've written some documentation and tests. I'd be very surprised if these functions are used in any package so I'll go ahead a merge this. |
Move rectuangular full packed matrix support from base to LinearAlgebra.jl
A grep can answer that question. @dmbates had asked about them, and it's entirely possible he's not the only person trying to do more exotic operations. |
|
I find the coveralls UI completely confusing. I have basically no idea how to, e.g., find what the percentage coverage for that file is from that link. |
When I did navigate to it (use the search thing), I see 89.02% coverage. Are we looking at the same thing? |
I swear it was 93% a few minutes ago. Oh well. 89% is still really good. |
Yes, it's great. This is really getting there. |
Is my guide at #11885 not clear enough? Could you suggest improvements? |
No, your guide is great. I'm really just venting that their UI is lousy. |
I think it's really cool that I have to click like 10 different things to get the information I want. |
The methods have never been exported or maintained so it should be safe to move them out of base. This also fixes #11072.