Fix MSVC build #12214
Merged
Fix MSVC build #12214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inconsistent linkage in gc functions due to moving the extern "C", and different spelling of _Static_assert
|
This is tiny now that @vtjnash fixed the pointer arithmetic parts, so I'll merge when green if nobody says otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
various complaints about unknown
void *size in pointer arithmetic (ref d81f6d2#commitcomment-12240818),inconsistent linkage in gc functions due to moving the
extern "C"in #11358,and different spelling of
_Static_assertfrom #12144Also need to replace the sysimg patch in #12056 with https://gist.github.com/bb6b600056bf2bbeb42a once this gets merged.