deprecate print_escaped, print_unescaped, and print_joined #16603
Conversation
| @@ -784,12 +784,12 @@ Equivalent to `stat(file).mode` | |||
| filemode | |||
|
|
|||
| """ | |||
| print_joined(io, items, delim, [last]) | |||
| join(io, items, delim, [last]) | |||
There was a problem hiding this comment.
removing square brackets around last or not? should be consistent between here and the rst docstring at https://github.com/JuliaLang/julia/pull/16603/files#diff-5024f6efcbbb7500d181c34103c2576a
There was a problem hiding this comment.
I wasn't sure if the signature-matching supported that, since it doesn't allow the brackets on the line below specifying which method is documented.
There was a problem hiding this comment.
by "the line below" do you mean the part outside the docstring? that needs to be valid julia syntax
There was a problem hiding this comment.
Yes I mean the part outside the docstring. Is it ok for the signature to have the brackets, but the part outside not to?
There was a problem hiding this comment.
Yeah. The brackets are just for presentation (and rst genstdlib matching), the part outside controls which method this particular docstring gets attached to, AIUI. I think we may eventually want to move from the bracket convention to strictly using Julia syntax in docstrings, but that's a decision for another day.
JeffBezanson
force-pushed
the
jb/misc_io_deprecations
branch
from
d27d052
to
2f3f412
Compare
JeffBezanson
force-pushed
the
jb/misc_io_deprecations
branch
from
2f3f412
to
39f2728
Compare
|
needs NEWS mention |
for the sake of bisecting ref JuliaLang/julia#16603
* Compat minimum version is 0.8.0 for show/writemime and unsafe_string * Be specific about print_escaped renaming for the sake of bisecting ref JuliaLang/julia#16603 * Remove probably-unnecessary at-static
|
|
* Compat minimum version is 0.8.0 for show/writemime and unsafe_string * Be specific about print_escaped renaming for the sake of bisecting ref JuliaLang/julia#16603 * Remove probably-unnecessary at-static
Part of #14052. Some redundant functions.