Fix compilation of src/ with MSVC #19416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC needs consistent linkage between prototype and implementation
tkelman
force-pushed
the
tk/fixmsvcbuild
branch
from
3d7866c
to
3622a51
Compare
tkelman
referenced
this pull request
Nov 25, 2016
in jl_codectx_t, change from typedef to struct
prevent mangling if compiled as C++
tkelman
force-pushed
the
tk/fixmsvcbuild
branch
from
3622a51
to
fbf1ad7
Compare
|
Is it possible (or desirable) to set up AppVeyor to build with MSVC instead of GCC? |
|
Not [desirable] right now. It's not fully supported, we just try to keep it compiling best-effort. See #12056 for what it would take to make MSVC really first class. |
|
I do test builds using my personal appveyor account on a branch of my fork that also has some messy hacks that shouldn't be upstreamed, so appveyor is useful for testing these, but we don't want to run it on every commit if the tests don't pass. |
tkelman
force-pushed
the
tk/fixmsvcbuild
branch
from
fbf1ad7
to
c2c40a6
Compare
|
Any objections to these changes? |
yuyichao
approved these changes
Dec 3, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to check whether af3f940 causes a warning on non-MSVC buildsnevermind, it didn't even compile without the cast on non-MSVC