Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of src/ with MSVC #19416

Merged
merged 6 commits into from
Dec 3, 2016
Merged

Conversation

tkelman
Copy link
Contributor

@tkelman tkelman commented Nov 25, 2016

Need to check whether af3f940 causes a warning on non-MSVC builds nevermind, it didn't even compile without the cast on non-MSVC

MSVC needs consistent linkage between prototype and implementation
in jl_codectx_t, change from typedef to struct
prevent mangling if compiled as C++
@ararslan
Copy link
Member

Is it possible (or desirable) to set up AppVeyor to build with MSVC instead of GCC?

@tkelman
Copy link
Contributor Author

tkelman commented Nov 25, 2016

Not [desirable] right now. It's not fully supported, we just try to keep it compiling best-effort. See #12056 for what it would take to make MSVC really first class.

@tkelman
Copy link
Contributor Author

tkelman commented Nov 25, 2016

I do test builds using my personal appveyor account on a branch of my fork that also has some messy hacks that shouldn't be upstreamed, so appveyor is useful for testing these, but we don't want to run it on every commit if the tests don't pass.

@tkelman
Copy link
Contributor Author

tkelman commented Dec 3, 2016

Any objections to these changes?

@tkelman tkelman merged commit ce49840 into JuliaLang:master Dec 3, 2016
@tkelman tkelman deleted the tk/fixmsvcbuild branch December 3, 2016 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
system:windows Affects only Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants