New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the FFTW bindings from Base #21956

Merged
merged 1 commit into from Jun 16, 2017

Conversation

Projects
None yet
5 participants
@ararslan
Member

ararslan commented May 18, 2017

Ready to merge!

This PR completely removes FFTW from Base. The bindings will instead be available in the FFTW.jl package in the JuliaMath organization. I'm still working on the package, but in the meantime I figured I'd put this up here to give folks a preview of what's to come.

Fixes #18389

@ararslan

This comment has been minimized.

Member

ararslan commented May 24, 2017

@jlbuild !nuke

Pkg.clone("https://github.com/JuliaMath/FFTW.jl.git")
Pkg.checkout("FFTW", "master")
Pkg.build("FFTW")
Pkg.test("FFTW")
@jlbuild

This comment has been minimized.

jlbuild commented May 24, 2017

Status of 65bb63f builds:

Builder Name Nuke Build Download Code Output
linux32 COMPLETE COMPLETE Download COMPLETE
linux64 COMPLETE COMPLETE Download ERRORED
linuxaarch64 COMPLETE COMPLETE Download ERRORED
linuxarmv7l COMPLETE COMPLETE Download COMPLETE
linuxppc64le COMPLETE COMPLETE Download COMPLETE
osx64 COMPLETE COMPLETE Download PENDING
win32 COMPLETE ERRORED N/A N/A
win64 COMPLETE ERRORED N/A N/A
@ararslan

This comment has been minimized.

Member

ararslan commented Jun 12, 2017

This is getting really close. This PR, AbstractFFTs, and FFTW are ready to go, I just need to finish up the DSP package.

@ararslan ararslan changed the title from WIP: Remove the FFTW bindings from Base to Remove the FFTW bindings from Base Jun 15, 2017

@ararslan

This comment has been minimized.

Member

ararslan commented Jun 15, 2017

The packages that inherited these functions are ready now, so this is good to go!

@ararslan ararslan requested a review from tkelman Jun 15, 2017

@ararslan

This comment has been minimized.

Member

ararslan commented Jun 16, 2017

Four hours in the CI queue after a rebase, but now it's good to go.

@StefanKarpinski

This comment has been minimized.

Member

StefanKarpinski commented Jun 16, 2017

do it

@ararslan ararslan merged commit 00b9ea2 into master Jun 16, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ararslan ararslan deleted the aa/farewell-fftw branch Jun 16, 2017

@ararslan

This comment has been minimized.

Member

ararslan commented Jun 16, 2017

i did it

@StefanKarpinski

This comment has been minimized.

Member

StefanKarpinski commented Jun 16, 2017

Probably should have tried this before we merged this, but I'm seeing this:

julia> fft(rand(10))
ERROR: UndefVarError: pkg not defined
Stacktrace:
 [1] #fft#6(::Array{Any,1}, ::Function, ::Array{Float64,1}, ::Vararg{Array{Float64,1},N} where N) at ./deprecated.jl:1448
 [2] fft(::Array{Float64,1}, ::Vararg{Array{Float64,1},N} where N) at ./deprecated.jl:1448
@JeffBezanson

This comment has been minimized.

Member

JeffBezanson commented Jun 16, 2017

Ah, string interpolation strikes again :trollface:

@ararslan

This comment has been minimized.

Member

ararslan commented Jun 16, 2017

Ah crap. Will fix.

@ararslan

This comment has been minimized.

Member

ararslan commented Jun 16, 2017

Fix in #22391

ararslan added a commit that referenced this pull request Jun 16, 2017

quinnj added a commit that referenced this pull request Jun 20, 2017

@martinholters

This comment has been minimized.

Member

martinholters commented Sep 21, 2017

Something is still not quite as it should here (or am I missing something?), but the problem might be with DSP.jl?

   _       _ _(_)_     |  A fresh approach to technical computing
  (_)     | (_) (_)    |  Documentation: https://docs.julialang.org
   _ _   _| |_  __ _   |  Type "?help" for help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 0.7.0-DEV.1776 (2017-09-14 03:47 UTC)
 _/ |\__'_|_|_|\__'_|  |  Commit deceb3be66* (7 days old master)
|__/                   |  x86_64-linux-gnu

julia> Pkg.status("DSP")
 - DSP                           0.3.2

julia> using DSP

julia> xcorr([1, 2], [3, 4])
ERROR: Base.DSP.xcorr has been moved to the package DSP.jl.
Run `Pkg.add("DSP")` to install it, restart Julia,
and then run `using DSP` to load it.
Stacktrace:
 [1] error(::Function, ::String, ::String, ::String, ::String, ::String, ::String, ::String, ::String, ::String) at ./error.jl:44
 [2] #xcorr#6(::Array{Any,1}, ::Function, ::Array{Int64,1}, ::Vararg{Array{Int64,1},N} where N) at ./deprecated.jl:126
 [3] xcorr(::Array{Int64,1}, ::Vararg{Array{Int64,1},N} where N) at ./deprecated.jl:126

OTOH:

julia> using DSP: xcorr

julia> xcorr([1, 2], [3, 4])
3-element Array{Int64,1}:
  4
 11
  6

Edit: Fixed in DSP.jl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment