Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around a llvm-config bug by creating a versioned symlink to libLLVM #30033

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Nov 14, 2018

Attempted fix for #29981

@maleadt
Copy link
Member Author

maleadt commented Nov 14, 2018

FWIW, I've seen this recommended by some other projects, eg. https://github.com/AccelerateHS/accelerate-llvm/blob/master/README.md#building-from-source

@maleadt
Copy link
Member Author

maleadt commented Nov 15, 2018

Turns out CI is pretty worthless here, since the macOS builder uses BinaryBuilder.
Confirmed to work locally though, with llvm-config now reporting --shared-mode as shared (and as a result listing libLLVM.dylib as --libfiles).
More importantly, the julia binary is back to 3MB, and LLVM.jl works again.

Is this good to go? Also confirmed to work with binary-dist:

$ tar -tvf julia-96ce5ba221-mac64.tar.gz
lrwxr-xr-x julia/staff       0 2018-11-14 11:38 julia-96ce5ba221/lib/julia/libLLVM-6.0.dylib -> libLLVM.dylib
-rwxr-xr-x julia/staff 42447980 2018-11-14 11:32 julia-96ce5ba221/lib/julia/libLLVM.dylib
-rwxr-xr-x julia/staff   3213496 2018-11-14 11:46 julia-96ce5ba221/lib/libjulia.1.1.dylib

@maleadt maleadt added building Build system, or building Julia or its dependencies system:mac Affects only macOS regression Regression in behavior compared to a previous version labels Nov 15, 2018
@vchuravy
Copy link
Member

I kicked off https://build.julialang.org/#/buildrequests/5154?redirect_to_build=true to check if it works on the buildbots as well.

@maleadt
Copy link
Member Author

maleadt commented Nov 16, 2018

I kicked off https://build.julialang.org/#/buildrequests/5154?redirect_to_build=true to check if it works on the buildbots as well.

Great, thanks! Looks like that went through and contains the symlink:

a julia-98b0264fb8/lib/julia/libLLVM-6.0.dylib
a julia-98b0264fb8/lib/julia/libLLVM.dylib

There's some test failures but those seem unrelated:

Error in testset FileWatching:
Test Failed at /Users/osx/buildbot-tabularasa/worker/tester_osx64/build/share/julia/stdlib/v1.1/FileWatching/test/runtests.jl:332
  Expression: events.changed && (!(events.timedout) && !(events.renamed))
Error in testset FileWatching:
Test Failed at /Users/osx/buildbot-tabularasa/worker/tester_osx64/build/share/julia/stdlib/v1.1/FileWatching/test/runtests.jl:332
  Expression: events.changed && (!(events.timedout) && !(events.renamed))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
building Build system, or building Julia or its dependencies regression Regression in behavior compared to a previous version system:mac Affects only macOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants