threads: expand thread-safe region for I/O #32309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
io
|
Does this make function such as uv_os_homedir which libuv states are not thread safe, thread-safe in Julia? |
|
I wouldn't rely too closely on the libuv docs 😜. I think that warning seems to have gotten fixed before the PR was merged. I'm not sure why the message got left in. Perhaps you'd like to delete it for them? |
This should hopefully cover most I/O operations which go through libuv to make them thread-safe. There is no scaling here, just one big global lock, so expect worse-than-single-threaded performance if doing I/O on multiple threads (as compared to doing the same work on one thread). The intention is to handle performance improvement incrementally later. It also necessarily redesigns parts of the UDPSocket implementation to properly handle concurrent (single-threaded) usage, as a necessary part of making it handle parallel (thread-safe) usage.
JeffBezanson
force-pushed
the
jn/thread-io
branch
from
7875088
to
cfd2a14
Compare
JeffBezanson
approved these changes
Jun 21, 2019
vtjnash
added a commit
that referenced
this pull request
Jun 26, 2019
After #32309, we became much more eager to forget about normal errors and more eager to throw an EOFError at the wrong place. This is intended to fix that oversight.
vtjnash
added a commit
that referenced
this pull request
Jun 27, 2019
After #32309, we became much more eager to forget about normal errors and more eager to throw an EOFError at the wrong place. This is intended to fix that oversight.
vtjnash
added a commit
that referenced
this pull request
Jul 11, 2019
After #32309, we became much more eager to forget about normal errors and more eager to throw an EOFError at the wrong place. This is intended to fix that oversight.
vchuravy
added a commit
that referenced
this pull request
Apr 21, 2020
It is noted as a non-OS stream, but has also been a subtype of LibuvStream since forever. #32309 did not add the `readerror` field.
JeffBezanson
pushed a commit
that referenced
this pull request
Apr 22, 2020
It is noted as a non-OS stream, but has also been a subtype of LibuvStream since forever. #32309 did not add the `readerror` field.
KristofferC
pushed a commit
that referenced
this pull request
May 10, 2020
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
This should hopefully cover most I/O operations which go through libuv to make them thread-safe. There is no scaling here, just one big global lock, so expect worse-than-single-threaded performance if doing I/O on multiple threads (as compared to doing the same work on one thread). The intention is to handle performance improvement incrementally later. It also necessarily redesigns parts of the UDPSocket implementation to properly handle concurrent (single-threaded) usage, as a necessary part of making it handle parallel (thread-safe) usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully cover most I/O operations that go through libuv (meaning that other operations like using IOStream files aren't part of this PR), to make them thread-safe.
The UDPSocket implementation of many things has been always wrong, this also fixes them.