-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GC.safepoint()
for compute-bound threads
#33092
Conversation
Inserts a point in the program where garbage collection may run. | ||
This can be useful in rare cases in multi-threaded programs where some threads | ||
are allocating memory (and hence may need to run GC) but other threads are doing | ||
only simple operations (no allocation, task switches, or I/O). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, but where would you put this call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An example would be pretty helpful here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naive question, and maybe this isn't the place to put this information, but why does the compute thread need to have a safepoint if it's not allocating any objects? If the other threads are allocating then they're hitting safepoints... so if the GC determines it needs to collect on one thread does it block and wait for all other threads to similarly block at safepoints before collecting?
Edit: so would that mean you'd want to structure it in the compute loop to run every N milliseconds, where N is near your maximum acceptable GC latency of the other threads and/or on the same order as the average time-to-safepoint of the other threads?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the GC determines it needs to collect on one thread does it block and wait for all other threads to similarly block at safepoints before collecting
Yes.
Running it every N milliseconds would be nice, but pretty fancy. If you can tolerate a bit of slowdown you can just throw it in a loop anywhere. It's only a single load instruction so it's not horribly expensive. I also wouldn't advise using it at all unless the computation takes a really long time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right — I wasn't imaging a timer, but rather giving the docs reader some sort of rule of thumb to allow them to do some reasoning about a rough number of inner loop iterations to run before hitting a safepoint. Of course, you also wouldn't want it in the lowest of loops as it'd break vectorizaton.
3f7142b
to
f69d542
Compare
This will now sometimes be needed to avoid long-running, non-allocating computations from blocking other threads from running GC. Of course it would be better to have codegen insert gc state transitions, but that is quite fancy and not necessarily free, so we might as well let people work around it manually for now.