-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install 7z.dll
to libexec
instead of bin
.
#33592
Conversation
This is required for `7z.exe` to load properly. I believe this was not caught in previous testing because if the `bin` folder is on the `PATH`, this is not necessary, however we definitely cannot rely on that.
Possible to add a test by setting |
...I guess not then |
No need to create merge commits for this type of 1-commit PRs imo. |
Presumably that explains this test failure for Electron.jl on 1.3-rc4.1? Having said that, shouldn't PkgEval have caught this? |
Yes, this should be the reason why. You should replace that direct invocation with something like this:
|
Please open a new issue with the full error message you're seeing, and the version of Julia you're using. |
This is required for
7z.exe
to load properly. I believe this was notcaught in previous testing because if the
bin
folder is on thePATH
,this is not necessary, however we definitely cannot rely on that.