add a deprecation for at-get! #34646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
the
deprecation
This was referenced Feb 15, 2020
bors bot
added a commit
to FluxML/Zygote.jl
that referenced
this pull request
Feb 22, 2020
517: Remove get! macro r=dhairyagandhi96 a=matsueushi The get! macro is imported but unused. It was deprecated by JuliaLang/julia#34611, JuliaLang/julia#34646 Co-authored-by: matsueushi <matsueushi@gmail.com>
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was surprised to see how many uses this had, so a deprecation warning seems warranted. Since this was never exported, an ol' fashioned noisy depwarn seems ok, and it can be removed in a future v1.x.