Improve inference in Docs and Markdown #37087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
approved these changes
Aug 18, 2020
KristofferC
approved these changes
Aug 18, 2020
timholy
force-pushed
the
teh/docs_inference
branch
from
e55763d
to
f447774
Compare
Because Docs is set to `@nospecialize` for the entire module, declaring types on input arguments makes a large difference in what methods get inferred. This heads off a number of completely impossible combinations.
timholy
force-pushed
the
teh/docs_inference
branch
from
f447774
to
000b59c
Compare
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
* Improve inference in Docs and Markdown Because Docs is set to `@nospecialize` for the entire module, declaring types on input arguments makes a large difference in what methods get inferred. This heads off a number of completely impossible combinations. * Improve Dict-creation typing in metadata()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Docs is set to
@nospecializefor the entire module, declaring types on input arguments makes a large difference in whatmethods get inferred. This heads off a number of completely impossible combinations.
It's worth noting that enough methods have
@nospecializearguments that it might be worth considering removing the module-global@nospecialize. I understand the convenience of the module-global version, but it made for some really bizarre headscratching for why we were getting asignature!(::Any, ::Expr)MethodInstance.