Use apple-m1 as the base mcpu for aarch64-apple-darwin
#44347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Apple devkits are all presumably returned to Apple at this point, it doesn't make sense to continue to build for the earlier a12 model, we should just build for the M1 explicitly. LLVM supports `-mcpu=apple-m1` since LLVM 13.0.0-rc1 [0]. Clang 13 (ships with Xcode 13) understands this, so it's a safe bet that this can be used with the C compiler that is generating this code as well. [0] llvm/llvm-project@a8a3a43
staticfloat
added
building
|
LGTM |
staticfloat
changed the title
apple-m1 as the base march for aarch64-apple-darwinapple-m1 as the base mcpu for aarch64-apple-darwin
I think you're mixing up vanilla LLVM with Apple Clang. Xcode up to 13.2.1 ships Apple Clang 13 which is based on upstream LLVM 12 (ref: https://en.wikipedia.org/wiki/Xcode#Xcode_11.x_-_13.x_(since_SwiftUI_framework)_2), but it's true that XCode 13.0+ (with at least version string |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Apple devkits are all presumably returned to Apple at this
point, it doesn't make sense to continue to build for the earlier a12
model, we should just build for the M1 explicitly. LLVM supports
-mcpu=apple-m1since LLVM 13.0.0-rc1 [0]. Clang 13 (ships withXcode 13) understands this, so it's a safe bet that this can be used
with the C compiler that is generating this code as well.
[0]
llvm/llvm-project@a8a3a43