Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.8 branch] CI (Buildkite): remove the .buildkite folder #44377

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Feb 28, 2022

This pull request was automatically generated using the following script:

declare -a arr=("master" "release-1.6" "release-1.7" "release-1.8")
for BASE_BRANCH in "${arr[@]}"
do
    echo "BASE_BRANCH: ${BASE_BRANCH:?}"
    cd $(mktemp -d)
    git clone git@github.com:JuliaLang/julia.git
    cd julia
    git checkout ${BASE_BRANCH:?}
    git checkout -B dpa/remove-buildkite-folder-${BASE_BRANCH:?}
    rm -rf .buildkite
    rm -rf .buildkite-external-version
    echo "main" > .buildkite-external-version
    git add -A
    git commit -m "[\`${BASE_BRANCH:?}\` branch] CI (Buildkite): remove the \`.buildkite\` folder"
    git push -f origin dpa/remove-buildkite-folder-${BASE_BRANCH:?}
    cd ..
done

@DilumAluthge DilumAluthge force-pushed the dpa/remove-buildkite-folder-release-1.8 branch 5 times, most recently from 331909a to 02f4222 Compare March 10, 2022 22:52
@staticfloat
Copy link
Sponsor Member

@DilumAluthge why don't we have buildkite statuses here? 😅

@DilumAluthge
Copy link
Member Author

I'll look into it now.

@DilumAluthge
Copy link
Member Author

I have documented the necessary steps here: JuliaCI/julia-buildkite#43

@DilumAluthge DilumAluthge force-pushed the dpa/remove-buildkite-folder-release-1.8 branch from 02f4222 to 7ceed17 Compare March 14, 2022 18:47
@DilumAluthge DilumAluthge marked this pull request as ready for review March 14, 2022 18:48
@DilumAluthge DilumAluthge requested a review from a team as a code owner March 14, 2022 18:48
@DilumAluthge DilumAluthge force-pushed the dpa/remove-buildkite-folder-release-1.8 branch from 6c74257 to 5de3463 Compare March 14, 2022 18:54
@DilumAluthge DilumAluthge removed the request for review from a team March 14, 2022 18:57
@DilumAluthge
Copy link
Member Author

@KristofferC FYI, this PR directly targets release-1.8. However, the only files modified by this PR are:

  1. .buildkite-external-version
  2. .buildkite/*
  3. .gitignore

None of those files should have an effect on PkgEval, so I think it's fine to merge this PR directly into release-1.8.

@DilumAluthge
Copy link
Member Author

Okay, Buildkite is now running on this PR.

@staticfloat If all Buildkite jobs pass on this PR, then it is good to merge from my point of view.

@DilumAluthge DilumAluthge added the ci Continuous integration label Mar 14, 2022
@staticfloat
Copy link
Sponsor Member

Looks like an ASAN failure. @tkf or @vtjnash is this expected on 1.8?

@DilumAluthge
Copy link
Member Author

Ah that's right, @vtjnash fixed asan in #44420.

We need to backport #44420 to release-1.8 before we can merge this PR.

@DilumAluthge DilumAluthge force-pushed the dpa/remove-buildkite-folder-release-1.8 branch from 3266b61 to 50a5688 Compare March 15, 2022 19:56
@staticfloat staticfloat merged commit 6195061 into release-1.8 Mar 15, 2022
@staticfloat staticfloat deleted the dpa/remove-buildkite-folder-release-1.8 branch March 15, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants