Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gc alloc instead of alloc typed in lowering #48642

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Use gc alloc instead of alloc typed in lowering #48642

wants to merge 5 commits into from

Conversation

wsmoses
Copy link
Contributor

@wsmoses wsmoses commented Feb 10, 2023

@vchuravy vchuravy added kind:embarrassing-bugfix Whoops! backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 status:merge me PR is reviewed. Merge when all tests are passing labels Feb 10, 2023
@vchuravy
Copy link
Sponsor Member

Remove the support for GCAllocTyped?

vchuravy
vchuravy reviewed Feb 13, 2023
View reviewed changes
src/jl_exported_funcs.inc
@@ -152,6 +152,7 @@
XX(jl_gc_add_finalizer_th) \
XX(jl_gc_add_ptr_finalizer) \
XX(jl_gc_add_quiescent) \
XX(jl_gc_alloc) \
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@staticfloat @vtjnash any reason why this wasn't included before?

Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not especially, though we try to make the API larger than necessary (this is not in src/julia.h for example), they get named mangled which is mildly annoying for debugging, and it is only needed for external C clients, not sysimg linking (which already gets direct access to all of libjulia-internal)

@giordano
Copy link
Contributor

This doesn't build

@KristofferC KristofferC removed the status:merge me PR is reviewed. Merge when all tests are passing label Feb 13, 2023
@vchuravy
Copy link
Sponsor Member

sigh

@KristofferC KristofferC mentioned this pull request Feb 20, 2023
Merged
50 tasks
@KristofferC KristofferC mentioned this pull request Mar 7, 2023
Merged
52 tasks
@KristofferC KristofferC mentioned this pull request Apr 9, 2023
Merged
26 tasks
@KristofferC KristofferC mentioned this pull request May 8, 2023
Merged
51 tasks
@KristofferC KristofferC mentioned this pull request Jun 6, 2023
Merged
36 tasks
@KristofferC KristofferC mentioned this pull request Jul 11, 2023
Merged
35 tasks
KristofferC added a commit that referenced this pull request Aug 18, 2023
@KristofferC
release-1.9: Backports for 1.9.3 (#50507)
a773c8b 
Backported PRs:
- [x] #47782 <!-- Generalize Bool parse method to AbstractString -->
- [x] #48634 <!-- Remove unused "deps" mechanism in internal sorting
keywords [NFC] -->
- [x] #49931 <!-- Lock finalizers' lists at exit -->
- [x] #50064 <!-- Fix numbered prompt with input only with comment -->
- [x] #50474 <!-- docs: Fix a `!!! note` which was miscapitalized -->
- [x] #50516 <!-- Fix visibility of assert on GCC12/13 -->
- [x] #50635 <!-- `versioninfo()`: include build info and unofficial
warning -->
- [x] #49915 <!-- Revert "Remove number / vector (#44358)" -->
- [x] #50781 <!-- fix `bit_map!` with aliasing -->
- [x] #50845 <!-- fix #50438, use default pool for at-threads -->
- [x] #49031 <!-- Update inference.md -->
- [x] #50289 <!-- Initialize prev_nold and nold in gc_reset_page -->
- [x] #50559 <!-- Expand kwcall lowering positional default check to
vararg -->
- [x] #49582 <!-- Update HISTORY.md for `DelimitedFiles` -->
- [x] #50341 <!-- invokelatest docs should say not exported before 1.9
-->
- [x] #50525 <!-- only check that values are finite in `generic_lufact`
when `check=true` -->
- [x] #50444 <!-- Optimize getfield lowering to avoid boxing in some
cases -->
- [x] #50523 <!-- Avoid generic call in most cases for getproperty -->
- [x] #50860 <!-- Add `Base.get_extension` to docs/API -->
- [x] #50164 <!-- codegen: handle dead code with unsafe_store of FCA
pointers -->
- [x] #50568 <!-- `Array(::AbstractRange)` should return an `Array` -->
- [x] #50871 <!-- macOS: Don't inspect dead threadtls during exception
handling. -->

Need manual backport:
- [ ] #48542 <!-- Add docs on task-specific buffering using
multithreading -->
- [ ] #50591 <!-- build: fix various makefile bugs -->


Non-merged PRs with backport label:
- [ ] #50842 <!-- Avoid race conditions with recursive rm -->
- [ ] #50823 <!-- Make ranges more robust with unsigned indexes. -->
- [ ] #50663 <!-- Fix Expr(:loopinfo) codegen -->
- [ ] #49716 <!-- Update varinfo() docstring signature -->
- [ ] #49713 <!-- prevent REPL from erroring in numbered mode in some
situations -->
- [ ] #49573 <!-- Implement jl_cpu_pause on PPC64 -->
- [ ] #48726 <!-- fix macro expansion of property destructuring -->
- [ ] #48642 <!-- Use gc alloc instead of alloc typed in lowering -->
- [ ] #48183 <!-- Don't use pkgimage for package if any includes fall in
tracked path for coverage or alloc tracking -->
- [ ] #48050 <!-- improve `--heap-size-hint` arg handling -->
- [ ] #47615 <!-- Allow threadsafe access to buffer of type inference
profiling trees -->
@IanButterworth IanButterworth mentioned this pull request Aug 19, 2023
Merged
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vchuravy vchuravy vchuravy left review comments

@vtjnash vtjnash vtjnash left review comments

Assignees
No one assigned
Labels
backport 1.8 Change should be backported to release-1.8 backport 1.9 Change should be backported to release-1.9 kind:embarrassing-bugfix Whoops!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wsmoses @vchuravy @giordano @vtjnash @KristofferC @DilumAluthge