Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add morespecific rule for hcat/vcat and Type{Union{}} #51718

Closed
wants to merge 1 commit into from
Closed

Add morespecific rule for hcat/vcat and Type{Union{}} #51718

wants to merge 1 commit into from

Conversation

fingolfin
Copy link
Contributor

Just like PR #49349 and resolves Nemocas/AbstractAlgebra.jl#1466

@fingolfin fingolfin mentioned this pull request Oct 15, 2023
Closed
vtjnash
vtjnash requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it is possible to overload hvcat for AbstractArray without causing type piracy and related issues. It is only currently allowed for adding other unrelated types. Additionally, the method here must have a Varargs of type Any to be like #49349

@brenhinkeller brenhinkeller added the compiler:latency Compiler latency label Oct 17, 2023
vtjnash
vtjnash reviewed Oct 17, 2023
View reviewed changes
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are definitely not right now, as they are ignoring the slurp parameter. The trouble is that these methods aren't disambiguating anything as the existing methods are supposed to be getting used for these cases and their supertypes.

@fingolfin
Copy link
Contributor Author

Thanks for the explanation @vtjnash

@fingolfin fingolfin closed this Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash requested changes

Assignees
No one assigned
Labels
compiler:latency Compiler latency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Loading this package breaks vcat(Union{}[])
3 participants
@fingolfin @vtjnash @brenhinkeller