Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nested precomp highlight debug #53111

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Jan 30, 2024

Fixes the pkgimage.mk stdlib dep tree which was slightly wrong and causing some nested precompilation

And adds debugs that identified the above issue, and have been useful for debugging #53081

i.e.

% JULIA_DEBUG=nested_precomp ./julia -q

(@v1.11) pkg> precompile
Precompiling project...
  103 dependencies successfully precompiled in 34 seconds. 40 already precompiled.
  2 dependencies had output during precompilation:
┌ FillArrays → FillArraysPDMatsExt
│  ┌ Debug: Nested precompilation: FillArraysPDMatsExt > FillArraysSparseArraysExt
│  └ @ Base loading.jl:2520
└  
┌ Symbolics → SymbolicsPreallocationToolsExt
│  ┌ Debug: Nested precompilation: SymbolicsPreallocationToolsExt > SymbolicsForwardDiffExt
│  └ @ Base loading.jl:2520
│  ┌ Warning: Module SymbolicsPreallocationToolsExt with build ID ffffffff-ffff-ffff-0008-f643010bcdb7 is missing from the cache.
│  │ This may mean SymbolicsPreallocationToolsExt [d479e226-fb54-5ebe-a75e-a7af7f39127f] does not support precompilation but is imported by a module that does.
│  └ @ Base loading.jl:2121
│  ┌ Error: Error during loading of extension SymbolicsPreallocationToolsExt of Symbolics, use `Base.retry_load_extensions()` to retry.

@IanButterworth IanButterworth added the packages Package management and loading label Jan 30, 2024
base/loading.jl Outdated Show resolved Hide resolved
@vchuravy
Copy link
Member

Should we fast-track f05f93d first?

KristofferC pushed a commit that referenced this pull request Jan 31, 2024
@IanButterworth IanButterworth changed the title Fix pkgimage.mk stdlib dep tree. Add nested precomp highlight debug Add nested precomp highlight debug Feb 8, 2024
@IanButterworth
Copy link
Member Author

#53112 is the follow-on for this

@IanButterworth IanButterworth added the merge me PR is reviewed. Merge when all tests are passing label Feb 8, 2024
@IanButterworth IanButterworth merged commit 63e95d4 into JuliaLang:master Feb 9, 2024
7 of 9 checks passed
@IanButterworth IanButterworth removed the merge me PR is reviewed. Merge when all tests are passing label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages Package management and loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants