Do not give StringVector
s to users
#54452
Open
+12
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
StringVector
v is aVector{UInt8}
which wraps memory allocated as a string. This allowsString(v)
to be zero-copy which is good for performance. However, if users are handed aStringVector
directly, they can use that to unknowingly mutate strings, which is illegal.For example, suppose a user calls a function
f
which returns aStringVector
v
. They can then do the following to mutate a strings
:The solution in this PR is to not ever let
StringVector
s escape out to the user, by instead returning normalVector{UInt8}
from the functions that would otherwise do so.For reviewers
Potential solution to #54434
Alternative to #54424
Still needs to be rebased on top of #54372 before merging, as these two PRs overlap quite a bit