Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

precompilepkgs: report direct dep ext errors #54741

Merged
merged 1 commit into from
Jun 10, 2024
Merged

precompilepkgs: report direct dep ext errors #54741

merged 1 commit into from
Jun 10, 2024

Conversation

IanButterworth
Copy link
Member

Fixes #54651

Precompiling all packages for 2 compilation configurations...
  ✗ Pkg → REPLExt
  ✗ Pkg → REPLExt --check-bounds=yes
  104 dependency configurations successfully precompiled in 58 seconds

ERROR: The following 2 dependencies failed to precompile:

REPLExt 

Failed to precompile REPLExt [e5eb5ef1-03cf-53a7-ae1d-5a66b08e832b] to "/Users/ian/Documents/GitHub/julia/usr/share/julia/compiled/v1.12/REPLExt/jl_liMRlA".
ERROR: LoadError: 
Stacktrace:
  [1] error()
    @ Base ./error.jl:53
  [2] top-level scope
    @ ~/Documents/GitHub/julia/usr/share/julia/stdlib/v1.12/Pkg/ext/REPLExt/REPLExt.jl:308
...

@IanButterworth IanButterworth changed the title use strict precompilation to catch stdlib ext failures precompilepkgs: report direct dep ext errors Jun 9, 2024
@IanButterworth IanButterworth mentioned this pull request Jun 9, 2024
Closed
@nsajko nsajko added bugfix This change fixes an existing bug package extensions compiler:precompilation Precompilation of modules error messages Better, more actionable error messages labels Jun 10, 2024
@IanButterworth IanButterworth merged commit ee651f4 into JuliaLang:master Jun 10, 2024
12 checks passed
@IanButterworth IanButterworth deleted the ib/precompile_strict branch October 1, 2024 13:39
@IanButterworth IanButterworth added the backport 1.11 Change should be backported to release-1.11 label Oct 1, 2024
IanButterworth added a commit to IanButterworth/julia that referenced this pull request Oct 1, 2024
@IanButterworth
precompilepkgs: report direct dep ext errors (JuliaLang#54741)
d41c7d5 
(cherry picked from commit ee651f4)
@IanButterworth IanButterworth mentioned this pull request Oct 1, 2024
Merged
IanButterworth added a commit that referenced this pull request Oct 1, 2024
@IanButterworth
[release-1.11] Backport: precompilepkgs report direct dep ext errors (#…
106e797 
…55955)

(cherry picked from commit ee651f4)

Backport of #54741
@KristofferC KristofferC mentioned this pull request Oct 7, 2024
Merged
44 tasks
@IanButterworth IanButterworth removed the backport 1.11 Change should be backported to release-1.11 label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KristofferC KristofferC KristofferC approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug compiler:precompilation Precompilation of modules error messages Better, more actionable error messages package extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

build stdlib precompiler doesn't report error detail for exts
3 participants
@IanButterworth @KristofferC @nsajko