Homogenize the progress bar in Pkg and base package precompilation #55588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The header was in `light_green` while in Pkg it was `green`. - The progress bar for downloading packages and artifacts was in green while compiling package was in blue. - The progress bar is now attached to the "Precompiling packages" header like for artifact and package downloads.
| end | ||
| t = Timer(0; interval=1/10) | ||
| anim_chars = ["◐","◓","◑","◒"] | ||
| i = 1 | ||
| last_length = 0 | ||
| bar = MiniProgressBar(; indent=2, header = "Progress", color = Base.info_color(), percentage=false, always_reprint=true) | ||
| bar = MiniProgressBar(; indent=0, header = "Precompiling packages ", color = :green, percentage=false, always_reprint=true) |
There was a problem hiding this comment.
Suggested change
| bar = MiniProgressBar(; indent=0, header = "Precompiling packages ", color = :green, percentage=false, always_reprint=true) | |
| bar = MiniProgressBar(; indent=0, header = "Precompiling packages", color = :green, percentage=false, always_reprint=true) |
Otherwise there's an extra space before the bar
There was a problem hiding this comment.
Which we don't do for artifacts
But we do have double space for registry downloads, which needs fixing in Pkg
There was a problem hiding this comment.
It was to line up the start of the artifact and download bar with the precompile bar.
There was a problem hiding this comment.
I think they're never all side by side so the inconsistent spacing seems odder than not being aligned?
There was a problem hiding this comment.
Either way seems an improvement so let's go with it and see how it looks
KristofferC
added a commit
that referenced
this pull request
Sep 12, 2024
…55588) - Fix a missing check to `always_reprint` that has been fixed in Pkg - The header was in `light_green` while in Pkg it was `green`. - The progress bar for downloading packages and artifacts was in green while compiling package was in blue. - The progress bar is now attached to the "Precompiling packages" header like for artifact and package downloads. Co-authored-by: KristofferC <kristoffer.carlsson@juliacomputing.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always_reprintthat has been fixed in Pkglight_greenwhile in Pkg it wasgreen.