Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep acronyms all upper-case #8175

Merged
merged 4 commits into from
Aug 29, 2014
Merged

Keep acronyms all upper-case #8175

merged 4 commits into from
Aug 29, 2014

Conversation

jakebolewski
Copy link
Member

Renames TcpSocket, UdpSocket, IpAddr to follow upper case acronym convention in base. #8165

@jakebolewski
Copy link
Member Author

UDPSocket is exported but TCPSocket is not. Should both be exported?

@Keno
Copy link
Member

Keno commented Aug 28, 2014

The reason we don't export TCPSocket is because there's no reason to construct it. In practice though, I think people embedding tcpsockets into their types is reason enough to export it.

@StefanKarpinski
Copy link
Member

Let's export it for consistency.

@ivarne
Copy link
Member

ivarne commented Aug 28, 2014

Would some sort of depreciation be relevant for this?

@StefanKarpinski
Copy link
Member

Unfortunately names are pretty hard to deprecate. Since 0.4 is going to be massively breaking, I think we can maybe just do the rename and packages that want to be 0.3-0.4 portable can just deal with it. Although it might be interesting to have some mechanism for allowing package to use the 0.4 idioms in a way that will continue to work on 0.3.

@ivarne
Copy link
Member

ivarne commented Aug 28, 2014

An alias for compatibility seems simple and better than nothing. We can also backport the new names as aliases in 0.3.1 so that stable master compatibility becomes less of a hassle.

@JeffBezanson
Copy link
Member

+1

I would add const aliases to deprecated.jl anyway, which we've done in the past. It's helpful to have a summary of changed names in one place, and also smooths the transition.

@IainNZ
Copy link
Member

IainNZ commented Aug 29, 2014

So those get removed when we tag 0.5-something wright?

JeffBezanson added a commit that referenced this pull request Aug 29, 2014
@JeffBezanson JeffBezanson merged commit b73bda4 into master Aug 29, 2014
ivarne added a commit to ivarne/julia that referenced this pull request Aug 29, 2014
After renaming some constants in JuliaLang#8175, it became harder to write the
same code to target 0.3.x and 0.4-dev. This PR potentially adds aliases,
so that when 0.3.1 gets released, less mainanance intrested package
authors can drop support for 0.3.0, and be compatible with both 0.3.1
and 0.4-dev with the same code base, without version conditionals.
@jakebolewski jakebolewski deleted the jcb/samecaps branch August 30, 2014 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants