Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ambiguity warning with SharedArray #9036

Merged
merged 1 commit into from
Nov 17, 2014

Conversation

Jutho
Copy link
Contributor

@Jutho Jutho commented Nov 17, 2014

As discussed here: #8432 (comment)

Apologies for commit 1c12bcb

I was trying to be fast and just edited this on Github, under the impression that this would create a pull request, rather than immediately a new commit.

@tkelman
Copy link
Contributor

tkelman commented Nov 17, 2014

I was trying to be fast and just edited this on Github, under the impression that this would create a pull request, rather than immediately a new commit.

If you don't have commit access to the repository then Github forks it and makes a new branch for you. When you do have commit access and you want to make a PR via the web interface, best to create a new branch from the dropdown first and do the edits there.

@Jutho
Copy link
Contributor Author

Jutho commented Nov 17, 2014

Yes, I learned this now. It was the first time I used the web interface for this (I wanted to try since I always read on the forum that people are stimulated to make small changes like this).

@tkelman
Copy link
Contributor

tkelman commented Nov 17, 2014

Regarding the issue at hand, it fixes the ambiguity warnings and doesn't introduce any new test regressions, so lgtm.

@Jutho
Copy link
Contributor Author

Jutho commented Nov 17, 2014

Ok, I hope this doesn't break anything unexpected, but the change seems small enough to be harmless.

Jutho added a commit that referenced this pull request Nov 17, 2014
fix ambiguity warning with SharedArray
@Jutho Jutho merged commit fd88252 into JuliaLang:master Nov 17, 2014
@Jutho Jutho deleted the jh/fixsharedarray branch January 8, 2015 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants