-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ruby / PostgreSQL plug-ins #22
Comments
ATM the Fedora package does not contain the plug-ins, because I was too busy with other Julia dependencies to care about them.
|
@nalimilan I added a strike trough to your comment in light of #21 |
Yeah, fine. Regarding the topic of the issue, maybe we can ask for help from somebody familiar with Ruby/PostgreSQL on the Julia mailing lists? There must be people like that around. |
Would there be any way to find current users of those extensions? I guess libutf8proc didn't have a mailing list. The published Ruby gem is a release behind: https://rubygems.org/gems/utf8proc shows v1.1.5. According to https://rubygems.org/api/v1/gems/utf8proc/reverse_dependencies.yaml there are three gems that depend on it: |
I'm inclined to leave that stuff out. |
Well, if we reclaim the name utf8proc, removing existing features would not be very nice to existing users. If all that's needed is to bring back the old code, I'd vote for keeping them. |
@nalimilan, I tend agree at first glance, with the caveat that I don't want to include the code unless we include a test script to validate it. |
Maybe Ruby has built-in facilities to normalize Unicode strings etc. nowadays? Or is there some other gem that has become the de-facto standard? e.g. this Ruby blog post mentions several alternatives, but not utf8proc, which makes me think that it's not popular with Ruby users. (As mentioned in #12, it would be good to benchmark utf8proc against unf, which seems to be the fastest library in that Ruby comparison.) Of course, maybe Ruby people should be using utf8proc, and would be using it if we are more aggressive about maintaining it and promoting it. But someone who actually uses Ruby should be the one to take the lead on that. |
(Also, I'm not really familiar with Ruby gems, but wouldn't the gem be the right place to maintain the Ruby plugin, rather than bundling it with utf8proc itself?) |
I agree, this seems like it just doesn't belong in utf8proc. |
leaving this link to the commit where these were deleted for future reference: c0f2b51 |
I know about PostgreSQL (not really Ruby) but do not use its plugins/extension. [I know they made changes in the recent past.] I found a fork: https://github.com/vlajos/libmojibake/blob/master/NEWS.md But, haven't found out how PostgreSQL manages. I'm not sure with the major version update, should this just be closed? |
There's also a fork apparently being used by the netsurf browser, ref http://source.netsurf-browser.org/libutf8proc.git/, we should try to reach out to them and see if we can collaborate on maintenance and merge their patches. Evidently Arch and Gentoo have been using them as "upstream" which is a little odd. |
cc @kyllikki on the above, I think you're the one who authored most or all of those patches? We'd be happy to review pull requests for any features or bug fixes you need. |
I've made a small Ruby gem that wraps utf8proc @ https://github.com/nomoon/utf8_proc. It appears to be a bit slower (0.5-2x) than the ubiquitous |
@nomoon, that sounds great, thanks for working on this. I will add a link to the utf8proc web page. |
@stevengj Cheers! I've just done some tweaking and am pretty certain it should work fine on any Ruby 2.0+ system that can locate utf8proc's headers and lib. I'm on OSX where that's as easy as |
These were in the original utf8proc, but I removed them in the libmojibake fork to focus on the C components. We can certainly add them back in easily (since the API is backward-compatible), and should distribute them in some form (bundled or separate?) in any case. My inclination is just to bundle them, but since I don't use those languages I'm worried about bitrot unless we can add a testsuite for them.
Are Ubuntu/Debian and Fedora distributing these plugins in their utf8proc packages, or are they just distributing the C library?
The text was updated successfully, but these errors were encountered: