-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data to Unicode 8.0.0 standard #45
Conversation
The test failure in this PR is because @staticfloat's cached data is not updated to 8.0.0, so the data generation script on Travis fails the comparison with the committed data file. Should we really have a test that will fail every time we update the Unicode tables? Granted it won't happen so often, but I'm not sure this particular test is that valuable. |
If I clear out the cached data, will that work for older version of utf8proc? |
I don't think so. We'd have a break where older versions have Unicode 7 tables while newer ones have Unicode 8 data. There's also the minor issue that I had to explicitly edit out the use of the cached Unicode data in order to actually update the tables, so the update procedure no longer works out of the box. |
Is there a version-dependent URL where we can get the data from, so it won't look like the same file to the caching server? I thought there was some checksum validation for staticfloat/cache.julialang.org#3 |
Actually, yes. |
Since the caching server only really pays attention to the basename, the versioned URLs unfortunately won't help us all that much. We'll have to come up with an elegant solution to that; maybe special-casing those URLs to have unique names on our S3 server (so they can both live side-by-side, and we know which one to serve)? It looks like the caching server notices the file has changed, attempts to change it, thinks its succeeded (the |
Nope, I was wrong, it is actually changing the file, and it gets the changes right the very first time. I'm not sure what the problems here are, but the caching server is serving the correct files out. |
I don't want the Unicode-table generation code to bitrot, so having it break on the rare cases where we update the Unicode support seems a small price to pay... |
@stevengj my original diagnosis doesn't seem to be correct, since the caching server apparently did notice the update to the Unicode data files. |
It should be noted however, that since the URL we've been asking for has changed its contents, older versions of |
I just restarted the build; if this doesn't work still I'll have to force the test to spit out more output. |
Rerunning the data generator seems to have fixed the problem. Will squash and commit. |
Update data to Unicode 8.0.0 standard
Merged and README updated. Is it time to tag a new version? |
A new stable version would be very useful for me to get Julia 0.4.0-dev in the Fedora development version. |
Yes, it seems like it's time for a new version. |
I remember you had loads of fun getting a new version of |
Closes #41
Some minor modifications to the julia script generator were needed.
There's some trailing whitespace in the generated file but I really don't feel like fixing it.