Fixes #22 #23
Merged
Fixes #22 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you add a test? |
|
Done |
|
Thanks for re-organizing testing code! Could you fix CI's? |
|
No problem, but I have an issue with those tests, it seems that testes are unstable. I have to set the seed of the liblinear, did you know how to do that? |
|
What OS are you using, and 32bit or 64bit? Previously tests on both mac and win32 are not so stable. |
|
Ubuntu 16.04 64bits |
|
I change to use L2R_LR but x86 is still not working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.