Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dims keyword for stack, unstack, unsqueeze #28

Merged
merged 2 commits into from
Jan 31, 2022
Merged

Conversation

CarloLucibello
Copy link
Member

Fix #25

@darsnack @ToucheSir should we do this? I'm not 100% convinced it is necessarily better

@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2022

Codecov Report

Merging #28 (3d632bf) into main (b45b273) will increase coverage by 0.02%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   89.52%   89.55%   +0.02%     
==========================================
  Files          14       14              
  Lines         401      402       +1     
==========================================
+ Hits          359      360       +1     
  Misses         42       42              
Impacted Files Coverage Δ
src/utils.jl 96.42% <90.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45b273...3d632bf. Read the comment docs.

@darsnack
Copy link
Member

If I were a completely new user (i.e. no Flux experience), the new conventions seem intuitive to me (based on Base conventions). Otherwise, I don't think there's much benefit. We could always support both but this is the best place to deprecate if we want to.

@CarloLucibello
Copy link
Member Author

Let's do this

@CarloLucibello CarloLucibello merged commit 2c33ff4 into main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use keyword dims for unsqueeze, stack, unstack
3 participants