Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port splitobs, shuffleobs, obsview #5

Merged
merged 4 commits into from
Dec 28, 2021
Merged

port splitobs, shuffleobs, obsview #5

merged 4 commits into from
Dec 28, 2021

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Dec 27, 2021

Changes:

  • In shuffleobs now rng is in the first position
  • In splitobs now at is a mandatory keyword arg
  • In splitobs now at can take integers or tuple of integers
  • Now getobs(a::SubArray) materializes the array
  • modernized the implementations (e.g. removed @generated)

@CarloLucibello CarloLucibello changed the title port splitobs, shuffleobs port splitobs, shuffleobs, obsview Dec 28, 2021
@CarloLucibello CarloLucibello merged commit c0e68f7 into main Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants