Implement table normalization #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
requested changes
Oct 2, 2021
There was a problem hiding this comment.
You should use different tables in the test set instead of modifying an existing test set that is working. Can you please copy the tables to a separate section in the test suite? That way we make sure that the tables that are being tested are not already normalized in the distance calculations.
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
reviewed
Oct 2, 2021
juliohm
requested changes
Oct 2, 2021
juliohm
approved these changes
Oct 2, 2021
|
Tests are failing, can you run locally and check that? |
juliohm
reviewed
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include tests for it.