Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coalesce #40

Merged
merged 3 commits into from
Apr 11, 2022
Merged

Add Coalesce #40

merged 3 commits into from
Apr 11, 2022

Conversation

eliascarv
Copy link
Member

@eliascarv eliascarv commented Apr 10, 2022

This PR adds the Coalesce transformation. The Coalesce(default) transformation replaces all missing values ​​with a default value.

@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2022

Codecov Report

Merging #40 (415e4fb) into master (ab30ce9) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
+ Coverage   92.57%   92.67%   +0.10%     
==========================================
  Files          16       17       +1     
  Lines         431      437       +6     
==========================================
+ Hits          399      405       +6     
  Misses         32       32              
Impacted Files Coverage Δ
src/transforms.jl 97.82% <ø> (ø)
src/transforms/coalesce.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab30ce9...415e4fb. Read the comment docs.

@eliascarv eliascarv requested a review from juliohm April 10, 2022 16:13
src/TableTransforms.jl Outdated Show resolved Hide resolved
src/transforms.jl Outdated Show resolved Hide resolved
src/transforms/coalesce.jl Show resolved Hide resolved
src/transforms/coalesce.jl Outdated Show resolved Hide resolved
@eliascarv eliascarv requested a review from juliohm April 11, 2022 22:00
Copy link
Member

@juliohm juliohm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now we need to add the transform to the table in the README.

@eliascarv eliascarv requested a review from juliohm April 11, 2022 22:55
@eliascarv
Copy link
Member Author

This PR is ready for a final review @juliohm!

@juliohm
Copy link
Member

juliohm commented Apr 11, 2022

Great, feel free to merge after the tests pass. 💯

@eliascarv eliascarv merged commit 7db1e56 into JuliaML:master Apr 11, 2022
@eliascarv eliascarv deleted the coalesce branch April 11, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants