-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RowTable and ColTable #65
Conversation
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 92.36% 92.46% +0.09%
==========================================
Files 19 21 +2
Lines 498 504 +6
==========================================
+ Hits 460 466 +6
Misses 38 38
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a first round of reviews. Feel free to add ColTable to this PR as well given that it is pretty much the same code.
Co-authored-by: Júlio Hoffimann <julio.hoffimann@gmail.com>
Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
Co-authored-by: Elias Carvalho <73039601+eliascarv@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, now we need to add the two transforms to the documentation like the other transforms.
Awesome! Thank you! 💯 |
Fix #62
Added RowTable transform and its tests.