Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix norm computation for empty vectors #106

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

mtanneau
Copy link
Contributor

@mtanneau mtanneau commented Apr 8, 2020

Addresses #105

@coveralls
Copy link

coveralls commented Apr 8, 2020

Pull Request Test Coverage Report for Build 2509

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+8.0%) to 46.797%

Files with Coverage Reduction New Missed Lines %
src/extras/misc.jl 9 9.09%
Totals Coverage Status
Change from base Build 2508: 8.0%
Covered Lines: 1169
Relevant Lines: 2498

💛 - Coveralls

@mtanneau
Copy link
Contributor Author

It looks like the build on Julia nightly fails due to an LLVM error

Executing the default test script
$ export JL_PKG=DoubleFloats
Package name determined from repository url to be DoubleFloats
$ julia --color=yes -e "if VERSION < v\"0.7.0-DEV.5183\"; Pkg.clone(pwd()); Pkg.build(\"${JL_PKG}\"); else using Pkg; if VERSION >= v\"1.1.0-rc1\"; Pkg.build(verbose=true); else Pkg.build(); end; end"
    Cloning default registries into `~/.julia`
######################################################################## 100.0%
      Added registry `General` to `~/.julia/registries/General`
   Updating registry at `~/.julia/registries/General`

LLVM ERROR: Cannot emit physreg copy instruction
The command "julia --color=yes -e "if VERSION < v\"0.7.0-DEV.5183\"; Pkg.clone(pwd()); Pkg.build(\"${JL_PKG}\"); else using Pkg; if VERSION >= v\"1.1.0-rc1\"; Pkg.build(verbose=true); else Pkg.build(); end; end"" failed and exited with 1 during .

Your build has been stopped.

I don't know what this error is, and all tests pass locally (I'm using Julia 1.4).

Can the build be manually re-triggered?

@JeffreySarnoff
Copy link
Member

It looks like the build on Julia nightly fails due to an LLVM error
Can the build be manually re-triggered?

Yes. It has been re-triggered.

@codecov-io
Copy link

Codecov Report

Merging #106 into master will increase coverage by 9.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   38.84%   47.93%   +9.08%     
==========================================
  Files          62       62              
  Lines        2505     3069     +564     
==========================================
+ Hits          973     1471     +498     
- Misses       1532     1598      +66     
Impacted Files Coverage Δ
src/math/linearalgebra/support.jl 100.00% <100.00%> (+13.33%) ⬆️
src/DoubleFloats.jl 50.00% <0.00%> (-50.00%) ⬇️
src/math/ops/op_dbfp_db.jl 50.00% <0.00%> (-16.67%) ⬇️
src/math/ops/op_fpdb_db.jl 33.33% <0.00%> (-12.83%) ⬇️
src/math/arithmetic/modpi.jl 38.57% <0.00%> (-8.80%) ⬇️
src/math/prearith/floorceiltrunc.jl 52.77% <0.00%> (-5.69%) ⬇️
src/extras/misc.jl 7.89% <0.00%> (-3.22%) ⬇️
src/math/arithmetic/normalize_hypot.jl 75.00% <0.00%> (-1.93%) ⬇️
src/extras/random.jl 10.29% <0.00%> (-1.78%) ⬇️
src/math/linearalgebra/matrixfunction.jl 17.39% <0.00%> (-1.66%) ⬇️
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0632f...c8e336a. Read the comment docs.

@JeffreySarnoff JeffreySarnoff merged commit 6dd6c09 into JuliaMath:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants