-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documenter built docs #285
Conversation
Set up doctests to start with 'using Interpolations'
To better control which part of the docs are going where, I moved the @autodocs blocks to api.md. I also added installation info to index.md
To better control the order of the documentation and to have all relevant information in the docs, I shortened the README and put all information into the docs/ folder.
Use pages keyword of makedocs() to set the order of the docs.
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=======================================
Coverage 47.36% 47.36%
=======================================
Files 21 21
Lines 1064 1064
=======================================
Hits 504 504
Misses 560 560 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, many thanks!
It's already a huge step forward. I think it's best to merge this with only the minor edits suggested below and then work collaboratively on making them better.
docs/make.jl
Outdated
"Library" => "api.md"] | ||
) | ||
|
||
deploydocs(repo="github.com/felixcremer/Interpolations.jl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done the necessary key setup for JuliaMath/Interpolations.jl, so you should be able to change this to point to this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. The documentation will only be built when the changes are merged, because the docs deployment is pointing on the master branch.
Change Documenter version to 0.21.0 to allow local nonprettyurls Fix link to convenience-notation
Thanks for the comments, I think this is now good to merge. |
This PR sets up Documenter built docs. These are at the moment visible at
https://felixcremer.github.io/Interpolations.jl/dev/
I split the README into small .md files in the docs/ folder and added these into the documentation.
I also included the docstrings at the end under Library splitted into Public and Internal API.
See also #273 for a discussion on the docstrings.
I think the docs need further work, and this could be a good starting point to see what docstrings are already there.
Somebody with a better understanding of the internals would need to check which parts of the doc/ folder is still relevant and need to be included.