Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documenter built docs #285

Merged
merged 7 commits into from
Dec 17, 2018
Merged

Add Documenter built docs #285

merged 7 commits into from
Dec 17, 2018

Conversation

felixcremer
Copy link
Contributor

This PR sets up Documenter built docs. These are at the moment visible at
https://felixcremer.github.io/Interpolations.jl/dev/
I split the README into small .md files in the docs/ folder and added these into the documentation.
I also included the docstrings at the end under Library splitted into Public and Internal API.
See also #273 for a discussion on the docstrings.

I think the docs need further work, and this could be a good starting point to see what docstrings are already there.
Somebody with a better understanding of the internals would need to check which parts of the doc/ folder is still relevant and need to be included.

Set up doctests to start with 'using Interpolations'
To better control which part of the docs are going where, I moved the @autodocs blocks
to api.md.
I also added installation info to index.md
To better control the order of the documentation and
to have all relevant information in the docs,
I shortened the README and put all information into the docs/ folder.
Use pages keyword of makedocs() to set the order of the docs.
@codecov-io
Copy link

codecov-io commented Dec 17, 2018

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   47.36%   47.36%           
=======================================
  Files          21       21           
  Lines        1064     1064           
=======================================
  Hits          504      504           
  Misses        560      560

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35de5f9...76f4fb0. Read the comment docs.

Copy link
Member

@timholy timholy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, many thanks!

It's already a huge step forward. I think it's best to merge this with only the minor edits suggested below and then work collaboratively on making them better.

docs/make.jl Show resolved Hide resolved
docs/make.jl Outdated
"Library" => "api.md"]
)

deploydocs(repo="github.com/felixcremer/Interpolations.jl")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done the necessary key setup for JuliaMath/Interpolations.jl, so you should be able to change this to point to this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed. The documentation will only be built when the changes are merged, because the docs deployment is pointing on the master branch.

docs/src/interpolations.md Outdated Show resolved Hide resolved
Change Documenter version to 0.21.0 to allow local nonprettyurls
Fix link to convenience-notation
@felixcremer
Copy link
Contributor Author

Thanks for the comments, I think this is now good to merge.

@timholy timholy changed the title WIP: Add Documenter built docs Add Documenter built docs Dec 17, 2018
@timholy timholy merged commit 0b7baf6 into JuliaMath:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants