Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IrrationalConstants and sinpi/cospi #40

Merged
merged 3 commits into from
Apr 8, 2022
Merged

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Mar 23, 2022

This PR simplifies the package and makes it more consistent with base Julia and the ecosystem. It

By using aliases one gets all existing functionality for twoπ and mod2pi for free.

Intentionally I did not fix JuliaMath/IrrationalConstants.jl#20 and #39 to avoid introducing any new functionality and definitions.

The main user-facing change is the re-definition of sintau(x::Integer) and costau(x::Integer) and that tau isa IrrationalConstant{:twoπ}. I'd argue that the former is a bugfix but maybe it is safer to make a breaking release, also due to the type change. Probably it does not matter though since the only direct dependent of Tau.jl 0.2.0 was PredictMDExtra (https://juliahub.com/ui/Packages/Tau/jo2zN/0.2.0?page=2) which however does not depend on Tau anymore (https://github.com/bcbi/PredictMDExtra.jl/blob/master/Project.toml, changed in 2019: bcbi/PredictMDExtra.jl#149).

cc: @hyrodium

@codecov
Copy link

codecov bot commented Mar 23, 2022

Codecov Report

Merging #40 (c3f187d) into master (4216830) will increase coverage by 2.94%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master       JuliaMath/Tau.jl#40      +/-   ##
===========================================
+ Coverage   97.05%   100.00%   +2.94%     
===========================================
  Files           2         1       -1     
  Lines          68         4      -64     
===========================================
- Hits           66         4      -62     
+ Misses          2         0       -2     
Impacted Files Coverage Δ
src/Tau.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4216830...c3f187d. Read the comment docs.

@devmotion devmotion requested a review from giordano March 23, 2022 07:46
Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

Project.toml Outdated Show resolved Hide resolved
devmotion and others added 2 commits April 8, 2022 22:18
Co-authored-by: Mosè Giordano <giordano@users.noreply.github.com>
@devmotion devmotion merged commit d2fd316 into master Apr 8, 2022
@devmotion devmotion deleted the dw/simplify_fix branch April 8, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exact results for triangular functions
2 participants