Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example about SCF callbacks #277

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Add example about SCF callbacks #277

merged 2 commits into from
Jul 8, 2020

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented Jul 7, 2020

No description provided.

@antoine-levitt
Copy link
Member

Nice. But can't we merge it with the custom solvers example?

@mfherbst
Copy link
Member Author

mfherbst commented Jul 8, 2020

We could, but I like having different examples to show different concepts. In this case solvers is numerics and this one is more about debugging and extracting information. I don't think there is a problem with having too many examples, but I also don't particularly mind.

@antoine-levitt
Copy link
Member

Problem is that having too many examples will become unreadable eventually. This falls under the same category of "let's inspect the SCF solver" and could give a nicely consistent tutorial when merged, but I don't particularly mind either way.

@mfherbst
Copy link
Member Author

mfherbst commented Jul 8, 2020

I see. I guess eventually we will need to go a bit more for topic and tutorial-oriented examples (like the bigger codes do), which will mean merging a few examples into a bigger one. I think we should see how it evolves and organically merge examples as we see need.

@antoine-levitt
Copy link
Member

ok

@mfherbst mfherbst merged commit d4678b5 into master Jul 8, 2020
@mfherbst mfherbst deleted the plotexample branch July 8, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants