Handling complex numbers for PairwisePotential #655
Merged
+183
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epolack
force-pushed
the
complex_pairwise
branch
from
84f3d04
to
d1e54bf
Compare
epolack
force-pushed
the
complex_pairwise
branch
2 times, most recently
from
0576459
to
88142d8
Compare
|
The tests may be a bit cryptic. Tell me if it may need more than some description of the steps. |
|
Is there an easy way to test for coverage without waiting for Github Actions? |
remove `kwargs` for `compute_forces`
|
Not really that I know of: you'd have to setup codecov locally I guess |
|
For this PR and others: can you mark the PRs as draft, and then mark it as finished when you want our review? Or indicate it in the issue or something. |
|
This one should be done. Coverage seems alright. |
|
Checks don't pass, but seems related to discussion with Niklass. Should be fine once merged to his version. |
|
Can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.